Code Review Checklist

  • No CI Errors
  • Good Commit Message
  • Code Follows Coding Conventions
  • Functions are commented
  • Code is Understandable
  • Code Addresses Requirements
  • Code is Consistent with Existing Codebase
  • Tests Cover Code Changes
  • Review Comments Added to Github
  • Functional Testing
  • Completed Checklist Item Added to LP Task

Questions to ask yourself about the code being reviewed:

  • How could I use or configure the app in such a way as to cause the code to fail?
  • Is the code in a state such that I can take over maintenance easily?
  • Is the code of the quality needed to be published in an article or book?